agama-project / agama / 15072306633

73%

push

github

feat(web): improve usability of installer L10n settings (#2359)

## Problem

Agama offers two different localization (l10n) configurations:

- One for the **installer interface** (language and keyboard layout).
- Another for the **installed product** (language, keyboard layout, and
timezone).

Despite being configured in different UI places, users often confuse
these settings. This leads to complaints when changing the "product"
language or keyboard layout, but still seeing the installer interface
remain unchanged.

Situation is particularly problematic with keyboard layouts, especially
when it comes to a password input.

## Solution

After considering and rejecting the idea of unifying both settings since
it could introduce more complexity and be harder to explain to users,
this PR improves **discoverability and clarity** of installer
localization settings:

- **Installer l10n settings are now shown in the top bar**, similar to
how some desktop environments do. Users can change installer language
and keyboard layout from there.
- When possible, these settings can also be **reused for the product to
install**.
- In modal dialogs holding a password input a **keyboard layout
selector** is displayed, since these dialogs block access to the top
bar.
- Some reminders are added near password inputs:
  - Current keyboard layout ( (in local connections only).
  - CAPS LOCK warning, if active.
- Keymap settings are only shown for **local connections**, since remote
sessions depend on the client system’s settings.

## Testing

- Added a unit test.
- Manually tested various scenarios.

92 of 132 branches covered (69.7%)

Branch coverage included in aggregate %.

10838 of 12167 relevant lines covered (89.08%)

61.33 hits per line