Unleash / unleash / 15063501268

86%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

chore: remove filterExistingFlagNames feature flag (#9957)

https://linear.app/unleash/issue/2-3564/remove-filterexistingflagnames-feature-flag

We're removing the `filterExistingFlagNames` feature flag since we've
decided we want this to be the default behavior.

We don't need to rush to merge it, just in case we need to disable this
for any reason. However it should also be pretty easy to just revert if
needed.

Changes in tests are a bit tricky since they assumed the previous
behavior where we always registered metrics, even for non existing flag
names. `cachedFeatureNames` is also memoized with a TTL of 10s, so the
easiest way to overcome this was to override `cachedFeatureNames` to
return what we expected. As long as they return the same flag names that
we expect, we're able to register their metrics.

Let me know if you can think of a better approach.

Run Details

3010 of 4065 branches covered (74.05%)

10 of 10 new or added lines in 2 files covered. (100.0%)

6 existing lines in 1 file now uncovered.

12136 of 14398 relevant lines covered (84.29%)

718.37 hits per line