kobotoolbox / kpi / 15037543969

81%

master: 76%

push

github

fix(attachmentStorage): fix UserProfile storage counter to exclude soft-deleted XForms TASK-1777 (#5687)

### 📣 Summary
Updates the management command to ensure that deleted projects (forms in
the trash) are no longer counted toward the user profile's attachment
storage usage.



### 📖 Description
Previously, when a user soft-deleted a project, the media files
associated with that form continued to be included in the UserProfile's
`attachment_storage_bytes` counter, which is used to track total storage
usage per account. This led to inconsistencies between the backend
storage counter and what users saw in the `/service_usage/` page, which
already excluded deleted forms.

This fix updates the `update_attachment_storage_bytes` management
command to exclude soft-deleted forms (`pending_delete=True`) from the
total storage calculation at the user profile level. Individual XForm
storage totals are still updated, even for trashed forms, so they remain
accurate if restored.

---------

Co-authored-by: Olivier Leger <olivierleger@gmail.com>

6230 of 9900 branches covered (62.93%)

7 of 7 new or added lines in 1 file covered. (100.0%)

23780 of 29381 relevant lines covered (80.94%)

1.6 hits per line