kobotoolbox / kpi / 15010315543

81%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(attachments): bulk and single attachment deletion endpoints TASK-1822 (#5733)

### 💭 Notes
Refactored endpoints for remove attachments:

- delete all attachments of a list of submissions, endpoint:
`/api/v2/assets/<asset_uid>/attachments/bulk/`

  -   receives a list of submission root_uuids as the payload
  -   users can only make `DELETE` requests
  -   returns a `202 ACCEPTED`

- delete a single attachment on an asset: 
`/api/v2/assets/<asset_uid>/attachments/<attachment_uid>/`
  - does not take any payload
  -  users can only make `DELETE` requests
  - returns a `204 NO CONTENT`



### 👀 Preview steps

#### Test: `/api/v2/assets/<asset_uid>/attachments/<attachment_uid>/`
1. ℹ️ have account and a project that has multiple attachments
2. Make some submissions with a few attachments
4. 🟢 Make a `DELETE` request using the uid of one attachment and verify
that you receive a `200 OK` response with the message: "1 attachments
deleted"
6. Check out the database 
7. Verify that the attachment is no longer present 
8. Verify that AttachmentTrash.objects.all().count() should be a least 1
11. Share the project with **another user** and grant them permission to
edit submissions
12. 🟢 Make a `DELETE` request as ** another user** and verify that you
receive a `200 OK`
13.  Grant  **partial user** partial permissions to edit submissions
12. 🟢 Make a `DELETE` request as ** partial user** and verify that you
receive a `200 OK`

#### Test: `/api/v2/assets/<asset_uid>/attachments/bulk/`
1. ℹ️ have account and a project that has attachments 
2. Make some submissions with a few attachments
3. Check out the new endpoint for the project:
`/api/v2/assets/<asset_uid>/attachments/bulk/`
4. 🟢 Make a `DELETE` request with a list of submission root uuids (see
example below) as a payload and verify that you receive a `202 ACCEPTED`
response with the message: "2 attachments deleted"
```
{
    "submission_root_uuids":
        [
        "3ed2e8de-b493-4367-a78d-346u687239... (continued)

Run Details

6092 of 9933 branches covered (61.33%)

60 of 65 new or added lines in 4 files covered. (92.31%)

1 existing line in 1 file now uncovered.

23109 of 29331 relevant lines covered (78.79%)

0.79 hits per line