kobotoolbox / kpi / 14834536167

81%

master: 76%

push

github

feat(attachments): update storage counters when attachments are moved to or from trash TASK-590 (#5686)

### 📣 Summary
Ensure storage counters are updated when attachments are trashed or
restored in ongoing projects.


### 📖 Description
This change improves storage accounting by updating
`attachment_storage_bytes` on both `UserProfile` and `XForm` when
attachments are soft-deleted or restored using
`AttachmentTrash.toggle_statuses()`.
- When an attachment is moved to the trash,
`pre_delete_attachment(only_update_counters=True)` is invoked to
decrement storage usage.
- When an attachment is restored, `post_save_attachment(created=True)`
is used to restore the counters.
- Logic is in place to prevent counters from being decremented twice if
the submission is deleted after the attachment has already been trashed.

---------

Co-authored-by: Olivier Leger <olivierleger@gmail.com>

6194 of 9859 branches covered (62.83%)

32 of 32 new or added lines in 2 files covered. (100.0%)

23664 of 29274 relevant lines covered (80.84%)

1.6 hits per line