Ouranosinc / xclim / 14733780119

92%

Build Type

push

github

Committed by web-flow

Commit Message

Allow unequal periods in `infer_sampling_units` and `stack_periods`. (#2150)

### What kind of change does this PR introduce?

* Allows the units "month" and "year" in the output of
`infer_sampling_units`.
* Rewrite `infer_sampling_units` to be more explicit in the errors and
safer with the defaults.

### Does this PR introduce a breaking change?
Yes, but minimal : `infer_sampling_units` would _assume_ `freq='D'`
before, which I now think is a bit weird and dangerous. It will now fail
on non-inferrable freqs instead, unless a default is passed.

### Other information:
Previously, the idea was that we would never use `pint` units that
represented unequal periods (months, years), but seeing the source issue
and thinking about it, maybe we can switch the usage responsibility to
the user instead? "month" and "year" are valid CF units, so why not
support them.

Run Details

18 of 19 new or added lines in 2 files covered. (94.74%)

1 existing line in 1 file now uncovered.

9739 of 10820 relevant lines covered (90.01%)

7.63 hits per line