Instagram / IGListKit / 14650732907
96%
master: 100%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Ran
Jobs 1
Files 54
Run time 94min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 97.135% (+0.009%) from 97.126%
14650732907

push

github

facebook-github-bot 
Add IGListAdapterDelegate Methods 3/n

Summary:
## CONTEXT
`IGListAdapterDelegate` currently has methods that are fired when an object is *first* displayed and when an object *ended* display on screen.  For many use cases this works but there are use cases in which it would be helpful to know whenever a cell will be displayed or ends display.  This is especially relevant in the `IGListAdapterDelegateAnnouncer` which will enable you to add code for tracking cells globally.  This change also balances the `IGListAdapterDelegate` with `IGListDisplayDelegate`  which has methods which include the cell as well

## PLAN
This diff will be go out in multiple parts
- delegate method addition (many file change due to our pattern of not preferring default implementation of protocol methods)
- Update to `IGListDisplayHandler` and `IGListAdapterDelegateAnnouncer` for invocation of delegate methods
- Unit test additions

## THIS DIFF
This diff updates the unit tests of `IGListAdapterDelegateAnnouncerTests`, `IGListAdapterE2ETests` and `IGListDisplayHandlerTests`.  We added new expectations and to existing unit tests because the functionality to confirm is already tested it was just only checking the existing delegate methods.  The new tests check the new methods as well

Reviewed By: maxolls

Differential Revision: D70406065

fbshipit-source-id: ee054a21f

4272 of 4398 relevant lines covered (97.14%)

710.48 hits per line

Jobs
ID Job ID Ran Files Coverage
1 iOS - 14650732907.1 58
97.12
 GitHub Action Run
Source Files on build 14650732907