djeedai / bevy_hanabi / 14602170426

66%

Build Type

push

github

Committed by web-flow

Commit Message

Fix `InitFillDispatchArgs` source offset (#458)

Fix the source buffer offset for the init fill dispatch pass reading from the
`GpuChildInfo` array the event count, and writing into the corresponding
`GpuDispatchIndirect` struct the number of workgroups to dispatch to handle
that number of events.

Remove the incorrect dependency to event buffers; the event buffers only store
the events themselves, which are unused here. Instead, the init fill dispatch
reads the event count, which is stored in the `GpuChildInfo` in a different
buffer.

Remove the dedicated `init_fill_dispatch` compute kernel; instead we can use
the generic `fill_dispatch` one since we're directly reading from and writing
to uniform arrays.

Create a separate batching queue type `InitFillDispatchQueue` for the indirect
init pass, which batches entries before they're submitted into the generic
queue of buffer operations. Remove all sorting from that generic collection,
now renamed `GpuBufferOperations`. Add support for separate queues of
operations submitted as transactional units and dispatched as a single compute
workload.

Fix `AlignedBufferVec::range_binding()` using the wrong (unaligned) item size,
leading to an incorrect binding.

Run Details

62 of 162 new or added lines in 3 files covered. (38.27%)

5 existing lines in 2 files now uncovered.

3041 of 7623 relevant lines covered (39.89%)

17.6 hits per line