kobotoolbox / kpi / 14601537627

81%

master: 76%

push

github

feature(attachments): make bulk delete attachments account for partial permissions TASK-559 (#5695)


### 📣 Summary
<!-- Delete this section if changes are internal only. -->
<!-- One sentence summary for the public changelog, worded for
non-technical seasoned Kobo users. -->

Displays the correct number of attachments/submissions in the UI when
bulk deleting based on current user permissions.

### 👀 Preview steps
<!-- Delete this section if behavior can't change. -->
<!-- If behavior changes or merely may change, add a preview of a
minimal happy path. -->
Feature/no-change template:
1. Have a form with submissions and `removingAttachmentsEnabled` flag
enabled
2. Give partial delete permissions to another user somehow. The way I
did it was:
    1. Have 2 accounts
2. Submit data logged in on both accounts (so there are submissions from
multiple accounts)
    3. Give one user permission to view submissions from both account
4. Give the same user in step above permission to only delete from one
account, let's call this the Test User.
6. As the Test User, select all submissions and click "Delete media
files only"
8. 🟢 notice that the number of attachments counted in the modal
correctly matches those that come from the submission(s) Test User can
delete
9. 🟢notice that after a successful "delete" the notify displays the
correct number of submissions that Test User can delete

---------

Co-authored-by: Leszek Pietrzak <leszek@magicznyleszek.xyz>

6134 of 9743 branches covered (62.96%)

23458 of 28971 relevant lines covered (80.97%)

1.6 hits per line