babelfish-for-postgresql / babelfish_extensions / 14591112169
77%

DEFAULT BRANCH: BABEL_5_X_DEV
Ran
Jobs 1
Files 116
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 75.14% (+0.007%) from 75.133%
14591112169

push

github

web-flow 
Adding support for sys.+ and sys.- for sys.bbf_varbinary data type (#3668)

1. Issue:

Before creating cast from varbinary to datetime, we found one issue that sys.+(sys.bbf_varbinary, sys.bbf_varbinary) and
sys.-(sys.bbf_vabinary,sys.varbinary) operators where pointing to sys.+(bigint, bigint) and sys.-(bigint, bigint)
respectively.

But after creating of cast from varbinary to datetime, sys.+(sys.bbf_varbinary, sys.bbf_varbinary) and
sys.-(sys.bbf_vabinary,sys.varbinary) operators started pointing to sys.+(sys.datetime, sys.datetime) and
sys.-(sys.datetime, sys.datetime) respectively.

Consider following example - 

-- previous version in BBF
1> declare @random varbinary(5) = 0x4142434445
2> declare @Result varbinary(max) = 0x
3> select @Result + @random
4> go
                    
--------------------
        280284578885

(1 rows affected)

-- after creation of cast in BBF
1> declare @random varbinary(5) = 0x4142434445
2> declare @Result varbinary(max) = 0x
3> select @Result + @random
4> go
Msg 517, Level 16, State 1, Server persist-rohitbgt-validation-17-latest-i, Line 3
data out of range for datetime

2. Changes made to fix the issues

The fix addresses the implementation of binary concatenation in Babelfish by adding support for operators like
sys.+(sys.bbf_varbinary, sys.bbf_varbinary). We utilize the existing 'bytecat' function, which provides equivalent
behavior to T-SQL's varbinary concatenation.

Task: BABEL-5728
Signed-off-by: yashneet vinayak <yashneet@amazon.com>

47917 of 63770 relevant lines covered (75.14%)

253043.69 hits per line

Jobs
ID Job ID Ran Files Coverage
1 14591112169.1 116
75.14
 GitHub Action Run
Source Files on build 14591112169