rust-bitcoin / rust-bitcoin / 14475495991
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 130
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.808% (+0.02%) from 83.785%
14475495991

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#4342: Remove Option return from `minimal_non_dust`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/0498f7b7b7d43cc015d6788efe826df25d6156a5">0498f7b7b<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/ee43f9235b5a7ebb24884ca7ad2351d1f9b05fce"> Remove Option return from `minimal_non_dust` (jrakibi)

Pull request description:

  Closes #4221

  This removes the `Option` return type from `minimal_non_dust

  Overflow is only possible in 2 cases:
  - `dust_relay_fee` would need to be excessively high
  - script size would have to exceed ~6.15 × 10¹⁵ bytes (≈ 6 petabytes)

  we now panic with the same message we had before in  https://github.com/rust-bitcoin/rust-bitcoin/blob/<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/cf12ba262a646a6341098ee3f4c178a52fc90211">cf12ba262</a>/bitcoin/src/blockdata/script/borrowed.rs#L412

ACKs for top commit:
  tcharding:
    ACK 0498f7b7b7d43cc015d6788efe826df25d6156a5
  apoelstra:
    ACK 0498f7b7b7d43cc015d6788efe826df25d6156a5; successfully ran local tests

Tree-SHA512: 826a5d4eb79b0318394ef34e8ae022b9cf0

4 of 7 new or added lines in 3 files covered. (57.14%)

22370 of 26692 relevant lines covered (83.81%)

16663.29 hits per line

Uncovered Changes

Lines Coverage ∆ File
2
93.93
 0.0% bitcoin/src/blockdata/transaction.rs
1
79.79
 0.11% bitcoin/src/blockdata/script/borrowed.rs
Jobs
ID Job ID Ran Files Coverage
1 14475495991.1 130
83.81
 GitHub Action Run
Source Files on build 14475495991