rust-bitcoin / rust-bitcoin / 14473710808

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4262: primitives: Make `hex` optional

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/a5f904559d3b5d2dfbcbed8b1746305e32103fee">a5f904559 primitives: Make hex optional (Tobin C. Harding)

Pull request description:

  Make the `hex` dependency optional. This means not implementing
      `Display` for some types if `hex` is not enabled and only implementing
      `Debug`.

      Also without `hex` enabled:

      - We loose the ability to parse an `OutPoint` from string because we
        can no longer parse `Txid`.

      - We loose the hex formatting of witness elements.

      Note also that `primitives` builds with the `serde` feature even if
      `hex?/serde` is excluded from the `serde` feature. I found this
      surprising.

  Close: #4183

ACKs for top commit:
  apoelstra:
    ACK a5f904559d3b5d2dfbcbed8b1746305e32103fee; successfully ran local tests

Tree-SHA512: c105e089551ea043aae48f6ef7853ceee91

Coverage Stats

12 of 12 new or added lines in 2 files covered. (100.0%)

8 existing lines in 2 files now uncovered.

22363 of 26691 relevant lines covered (83.78%)

16661.57 hits per line