agama-project / agama / 14465651065
73%

DEFAULT BRANCH: master
Ran
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
14465651065

push

github

web-flow 
Fix iBFT detection and rearrange iSCSI initiator page (#2269)

## Problem

Although the iBFT configuration was being properly applied if found, the
web user interface was always displaying "iBFT: no". See
[bsc#1239046](https://bugzilla.suse.com/show_bug.cgi?id=1239046).

Even if we can say that was just a cosmetic issue, it is fair to say the
original interface was not helping to make things understandable.

See the following screenshot in which several things are wrong:


![fake](https://github.com/user-attachments/assets/007a9f41-a11d-486e-9d7c-d71b98782a2e)

- As mentioned, the value of the column "iBFT" of the initiator should
be "yes".
- The action to edit the initiator name was always available, even for
initiators configured via iBFT.
- The column "Offload card" is obsolete, YaST does not longer use such a
field and it has never been possible to configure that via AutoYaST.

Last, but not least, that interface was not consistent with the design
principles used on the most modern sections of the Agama interface.

## Solution

First of all, this pull request fixes detection of iBFT for the user
interface. So now the interface can actually tell whether iBFT is in
use.

On top of that, this pull request reorganizes the interface a bit
showing this in case iBFT is in use (slightly outdated screenshot).


![ibft](https://github.com/user-attachments/assets/ab58913e-ed53-44f1-bfb6-bcd2f206b212)

And this in case iBFT is not detected.


![ibfnot](https://github.com/user-attachments/assets/b19873ec-7ff8-4d2b-9568-456f226a0442)

That is more aligned with the current interface and capabilities of
Agama and should help reducing confusion.

## Testing

- Tested manually by mocking the system (I don't have iBFT devices at
hand)
- Adapted unit tests
Source Files on build 14465651065
Detailed source file information is not available for this build.