PrincetonUniversity / PsyNeuLink / 14423804541

85%

master: 85%

push

github

tests: Drop unused function arguments (#3248)

There were several cases of unused arguments in test functions:

Test names in test parameters. These were converted to use pytest.param(..., id=name) instead
A fixture with unused value was converted to 'usefixture' decorator.
Unused autoparametrizing fixture. This would execute identical tests multiple times. The use of fixture was removed.
Unused parameterized arguments. These would lead to multiple executions of identical tests. These were converted to reduced parametrization instead.

The primary motivation was to avoid multiple executions of identical tests in the cases of unused parameterized arguments or auto-parametrizing fixtures, the other cases were modified to allow automatic enforcement.
Automatic enforcement was added in the form of flak8 linter that checks for unused function arguments and fails the CI build if there are any unused arguments in tests.

9888 of 12932 branches covered (76.46%)

Branch coverage included in aggregate %.

34489 of 39520 relevant lines covered (87.27%)

0.87 hits per line