kobotoolbox / kpi / 14384237089

81%

master: 76%

push

github

refactor(map): TypeScriptize Project Data Map files DEV-16 (#5558)

### 💭 Notes
Changes here:
- Improved map related actions definitions in `actions.d.ts`
- Renamed map related files
- `MapSettings`
  - Split out `MapColorPicker` component out of `MapSettings` file
  - Map settings tabs use enum now instead of string
  - Dropped `autoBind` and listener mixins
  - Split one translation into two (acted on TODO comment)
- `FormMap`
  - Is now `index.tsx` file
- Standardized some error handling in the file (there is still room for
improvement, but there is high chance we would be rewriting this whole
route :shrug:, handling errors was useful for me debugging things, so I
left the code there and polished a bit)
  - Improved the flow of handling asset files fetch response
    - `removeUnknownLayers` function is doing a cleanup
- `addNewLayers` is ensuring all different file types end up using the
same `onOmnivoreLayerReady` callback instead of relying on things "just
working"
- GeoJSON is being validated before being rendered (avoids code
crashing)
  - Dropped `state.loading` as it wasn't being used for anything really
- Added `@placemarkio/check-geojson` for validating GeoJSON (omnivore
sadly doesn't do it, resulting in crashing UI when invalid GeoJSON is
added)
- Created some simple types for `@mapbox/leaflet-omnivore`

### 👀 Preview steps

Ideally test this branch with bunch of layer files ([map test
files.zip](https://github.com/user-attachments/files/19008653/map.test.files.zip))
- csv - Dentists in Calderdale April 2023.csv
- geojson - Data Mill North - Leeds litter bin locations 20211201.json
- geojson - Pedestrian Crossings.json
- geojson (invalid) - Natural Earth’s vector data, version 4.1.0
land-110m.json
- kml - lava field extend from the 2023-2024 svartsengi eruption
20231218.kml
- kmz - earths-tectonic-plates-earthref.kmz
- kmz - Smithsonian_volcanoes.kmz
- wkt - Pedestrain Crossings converted_2025-02-26T14_32_34.330Z.wkt
- wkt (invalid) - samp... (continued)

6159 of 9761 branches covered (63.1%)

23345 of 28847 relevant lines covered (80.93%)

0.81 hits per line