kobotoolbox / kpi / 14316727648

81%

master: 76%

push

github

feat(nlp): processing view button conditional rendering TASK-1715 (#5631)

### 📣 Summary

Hide "Open" button in Data Table for `audio` question responses that now
have deleted attachment and no NLP features in use.

### 💭 Notes

Changes here:
- `AudioCell` now requires whole `SubmissionResponse` rather than just
uuid
- `AudioCell` now hides "Open" button for submission with no NLP
features being used (this is both for submissions that never used NLP,
and submission that used NLP but no logner has transcript, translations
and qual questions responses)
  - `removeEmptyObjects` function for recursively removing empty objects
- `removeEmptyFromSupplementalDetails` function for cleaning up
`supplementalDetails` from any leftover values that means "empty" (e.g.
submission with removed translation, submission with qualitative
analysis question response removed, etc.)
- Tiny positioning fix for Data Table rendering `AudioCell` with just
"Deleted" (no "Open" button)
- Added tests for two new utility functions
- I plan to migrate tests files to typescript in next PR, as I didn't
want to do too much in single PR. I expect there will be some changes
forced by TS

### 👀 Preview steps

Testing:
1. ℹ️ Have NLP features set up (see
https://www.notion.so/kobotoolbox/Setting-up-NLP-and-Languages-bb607e3fed114993bb14338fe56c6ed4?pvs=4)
2. ℹ️ Have account and a project with `audio` question
- Tip: for me it was helpful to also have `text` question in there, so I
could keep a note which submission is which test case 🧑‍🏫
4. ℹ️ Make 8+ submissions, each with `audio` question having a response
5. Go to Project → Data → Table and use "Open" button for the `audio`
question response (to open NLP view)
   - 1st submission: create transcript
- 2nd submission: create transcript, create translation, and delete
transcript
- 3rd submission: create qualitative analysis question and respond to it
   - 4th submission: don't create anything
   - 5th submission: create transcript, and del... (continued)

6141 of 9741 branches covered (63.04%)

23301 of 28800 relevant lines covered (80.91%)

0.81 hits per line