14142295843
83%

Ran 29 Mar 2025 05:38AM UTC

Jobs 1

Files 57

Run time 1min

Badge

Embed ▾

Committed 28 Mar 2025 10:22AM UTC coverage: 85.586% (+0.1%) from 85.467%

Build # 14142295843

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Duplicate Raft nodes during restart (#6732)

Antithesis triggered duplicate Raft nodes with the following scenario:
- follower needs to catchup based on snapshot, but is leaderless, so
results in: `catchup aborted, no leader`
  - call to `mset.resetClusteredState(..)` attempts to restart Raft node
  - `mset.stop(..)` call resets `sa.Group.node = nil`
  - goes into `js.createRaftGroup(..)` and waits for Raft node to stop
- in the meantime this folllower gets a snapshot from the meta layer,
which updates/checks the stream assignment
  - update notices `sa.Group.node == nil`
- does another call to `js.createRaftGroup(..)`, and also waits for Raft
node to stop
- now Raft node stops and both `js.createRaftGroup(..)` calls duplicate
the Raft node
- health check now notices `Detected stream cluster node skew`, deletes
node and resets

This fix ensures we can't create duplicate Raft nodes for the same
group.

It's unlikely to hit this normally due to requiring exact timing and
leaderless condition on the stream while having a leader for the meta
layer. But was easily reproducible in a test by just calling
`js.createRaftGroup` in parallel.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

Run Details

69426 of 81118 relevant lines covered (85.59%)

506614.94 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	86.48	-0.06%	src/github.com/nats-io/nats-server/server/accounts.go
2	86.08	0.1%	src/github.com/nats-io/nats-server/server/events.go
2	81.28	-0.04%	src/github.com/nats-io/nats-server/server/opts.go
2	90.96	-0.19%	src/github.com/nats-io/nats-server/server/parser.go
3	90.63	0.04%	src/github.com/nats-io/nats-server/server/leafnode.go
4	83.41	0.73%	src/github.com/nats-io/nats-server/server/filestore.go
4	73.52	0.14%	src/github.com/nats-io/nats-server/server/jetstream_api.go
4	52.92	0.0%	src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
9	94.82	-0.21%	src/github.com/nats-io/nats-server/server/client.go
10	88.01	0.32%	src/github.com/nats-io/nats-server/server/consumer.go
25	85.07	0.23%	src/github.com/nats-io/nats-server/server/raft.go
341	81.67	-0.17%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	14142295843.1	29 Mar 2025 05:38AM UTC	57	85.59	GitHub Action Run

nats-io / nats-server / 14142295843
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 14142295843

nats-io / nats-server / 14142295843 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 14142295843

nats-io / nats-server / 14142295843
83%

README BADGES
x