rust-bitcoin / rust-bitcoin / 14084979206

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3916: io: Remove the `impl_write` macro

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/280eb2239a2fcaa83a35ae6fb1ce62fe35a1e222">280eb2239 io: Remove the impl_write macro (Tobin C. Harding)

Pull request description:

  We have found calling macros from other crates to be error prone, especially when they involve feature gates. Furthermore the `impl_write` macro is trivial to write, users can just write it in the crate that needs it.

  Lets just remove the macro. While we are at it point users to the examples in `bitcoin/examples/io.rs` for usage of the `io` crate.

  Close: #3872

ACKs for top commit:
  Kixunil:
    ACK 280eb2239a2fcaa83a35ae6fb1ce62fe35a1e222
  apoelstra:
    ACK 280eb2239a2fcaa83a35ae6fb1ce62fe35a1e222; successfully ran local tests

Tree-SHA512: 62766ff6e8effd4399d2b7eca26dc8f1b67

22195 of 26602 relevant lines covered (83.43%)

16777.86 hits per line