rust-bitcoin / rust-bitcoin / 14074973980

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4279: `Witness` api improvements and test cleanups

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/84bee2f7b06a7bd1f435aaad18fa76a15188326e">84bee2f7b<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/143531de7c950954d1edea6a89c395553430d271"> Simplify `Witness` construction in tests (Martin Habovstiak)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3551ec2c698fe682da972e727da63cf1d574818f">3551ec2c6</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/143531de7c950954d1edea6a89c395553430d271"> Don&#39;t access internalls of `Witness` in tests (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c8078360d24d2e1de85a31a2e97a7a4fe96c7912">c8078360d</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/143531de7c950954d1edea6a89c395553430d271"> Impl `PartialEq` between `Witness` and containers (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/587a66da4760424ef20676c46251488cd84d350e">587a66da4</a> Add a bunch of missing conversions for `Witness` (Martin Habovstiak)

Pull request description:

  This is supposed to go in front of #4250

  `Witness` lacked a bunch of APIs that were making it harder to use and test, so this also adds them in addition to cleaning up tests. (I only realized they are missing when I tried to clean up tests and got a bunch of errors.)

ACKs for top commit:
  tcharding:
    ACK 84bee2f7b06a7bd1f435aaad18fa76a15188326e
  apoelstra:
    ACK 84bee2f7b06a7bd1f435aaad18fa76a15188326e; successfully ran local tests

Tree-SHA512: 7973f2a568e77956add0958e4ac1e2c79eb

42 of 85 new or added lines in 2 files covered. (49.41%)

22201 of 26602 relevant lines covered (83.46%)

16744.11 hits per line