kobotoolbox / kpi / 13971944506

81%

master: 76%

push

github

feat(attachments): add download and delete buttons TASK-571 (#5599)

### 💭 Notes

We don't touch the Project > Data > Gallery in MVP, so this would be the
only place that we don't give option to delete attachments from.

Changes here:
- `AttachmentActionsDropdown` now displays "Delete" button in red color
(Tessa's request)
- `AttachmentActionsDropdown` uses `<a>` for "Download" button for
better UX
- `AudioPlayer` has option to render things in "right section"
- `SidebarSubmissionMedia` uses `AttachmentActionsDropdown`
- `SidebarSubmissionMedia` doesn't handle "video" question types anymore
(we weren't using this option)
- `MediaCell` (and `TableMediaPreview`) now handles "file" question
types
- `MediaCell` now displays filename next to the icon
- Reasoning: previously `file` was displaying filename there, and it is
definitely useful to see it. I decided to change this for the other
types as well, as it is better to see some different text next to icon
rather than the identical icon for all submissions
- `MediaCell` uses `AttachmentActionsDropdown`
- Created `markAttachmentAsDeleted` utility function that adds
`is_deleted` flag to given attachment in a submission data object
- `SubmissionDataTable` now reacts to attachment being deleted, and
causes two things:
1. memoized submission data in `SubmissionModal` is being updated (using
`markAttachmentAsDeleted`)
2. `DataTable` is force refreshing submissions, so that it renders the
deleted attachment (this will be visible once `is_deleted` flag is being
handled)
- Fixed `DataTable` listener for
`actions.resources.refreshTableSubmissions`, as we broke it recently
(probably I did it when migrating to TS)
- Fixed `TableBulkCheckbox` default export (it worked previously, but
now Biome was complaining)

### 👀 Preview steps

Case A: testing steps for Submission Modal:
1. ℹ️ Have a project with `audio`, `file`, `image`, and `video` question
2. Make a submission that has responses to all the questions
- go to Pro... (continued)

6018 of 9567 branches covered (62.9%)

22983 of 28424 relevant lines covered (80.86%)

0.81 hits per line