#38028
23%

Ran 15 Mar 2025 08:31AM CUT

Jobs 1

Files 210

Run time 1min

Badge

Embed ▾

Committed 15 Mar 2025 07:57AM CUT coverage: 20.131% (+0.1%) from 19.998%

Build # #38028

Build Type

push

local

Committed by

web-flow

Commit Message

lowering: Don't closure-convert in `import` or `using` (#57774)

Fixes #57702. We're calling cl-convert- on `using` and `import`
statements when we shouldn't, so if there's a nearby local that gets
boxed (recursive function definition in this case), and the local shares
a name with something in an import statement, we get a box access where
we want a raw symbol.

Before:
```
julia> let; let; import SHA: R; end; let; R(x...) = R(x); end; end
ERROR: TypeError: in import, expected Symbol, got a value of type Expr
Stacktrace:
 [1] top-level scope
   @ REPL[1]:1
```

After:
```
julia> let; let; import SHA: R; end; let; R(x...) = R(x); end; end
(::var"#R#R##0") (generic function with 1 method)
```

Previously, symbols in `import`/`using` statements would be wrapped with
`outerref`, which cl-convert- wouldn't peek into. This protected us from
this problem in 1.11.

Run Details

9803 of 48697 relevant lines covered (20.13%)

120021.83 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	31.81	0.86%	base/client.jl
1	22.63	-0.19%	base/iterators.jl
1	20.05	0.11%	base/show.jl
3	48.45	2.48%	base/error.jl
3	54.05	-2.11%	base/libuv.jl
3	37.89	-3.16%	base/logging/ConsoleLogger.jl
35	23.41	2.07%	base/errorshow.jl
63	10.47	-0.04%	base/range.jl
319	9.31	0.09%	base/multidimensional.jl
472	0.39	0.02%	stdlib/REPL/src/REPL.jl
559	10.76	-0.08%	base/loading.jl

Jobs

ID	Job ID	Ran	Files	Coverage
1	#38028.1	15 Mar 2025 08:31AM CUT	210	20.13

Source Files on build #38028

File	Lines	Relevant	Missed
base/special/exp.jl	487	226	226
base/shell.jl	495	127	127
base/hamt.jl	274	117	117
base/ryu/fixed.jl	181	149	149
base/secretbuffer.jl	230	107	107
base/flparse.jl	18	5	5
base/abstractarraymath.jl	601	151	151
base/docs/bindings.jl	47	19	19
base/checked.jl	380	105	105
base/special/log.jl	586	162	162

21.95
base/
13.2
stdlib/

JuliaLang / julia / #38028
23%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #38028

JuliaLang / julia / #38028 23%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #38028

JuliaLang / julia / #38028
23%

README BADGES
x