kobotoolbox / kpi / 13816410500

81%

master: 76%

push

github

style(frontend): enable auto-fixable Biome linter rules (#5578)

### 💭 Notes

Enabled and run all rules with a **safe fix**, but manually reviewed
nevertheless. See commit-by-commit.
- noEmptyInterface
- useShorthandFunctionType
- useSelfClosingElements
- useNumberNamespace
- useImportType
- useEnumInitializers
- useConst
- useCollapsedElseIf
- noNegationElse
- noInferrableTypes
- noUnusedImports
- noInferrableTypes
- useRegexLiterals
- noUselessThisAlias
- useArrowFunction

Manually adjusted few places:
- put back a few comments that were automatically deleted along the line
after it.
- manually intervened
[here](https://github.com/kobotoolbox/kpi/compare/kalvis/biome-autofix?expand=1#diff-39ee38caab05dda3268179706640a1703L177-L187)
as the auto-fix was confused how to split up the comment, please review.

Notable exception to "all auto-fixable rules" is `useNamingConvention`,
because that is worth it's own PR due an opinionated configuration and
amount of expected changes.


### 👀 Preview steps

Users:
- Nothing *should* change. Click around and see nothing crashing.

Developers:
- open any ts/js file.
- write a problem, e.g.
    ```ts
    const a = [1, 0, 2].sort(function (a,b) { return b-a })
    ```
- :green_circle: in VSCode, notice a linter problem
- :green_circle: notice that `npm run lint:biome` errors
- :green_circle: in VSCode, notice an auto-fix on save

6019 of 9555 branches covered (62.99%)

22969 of 28398 relevant lines covered (80.88%)

0.81 hits per line