cybertec-postgresql / pgwatch / 13812635775

74%

Build Type

push

github

Committed by web-flow

Commit Message

[!] refactor `reaper` package and `sinks.MultiWriter` (#667)

[!] refactor `reaper` package and `sinks.MultiWriter`
- make MultiWriter implement Writer interface
- if there is only one target sink, return it instead of MultiWriter
- move WriteMeasurements() to Reaper struct
- make NewReaper() constructor responsible for read/write inits
- rename SyncMetricDefs() to Reaper.ReadMetrics()
- improve Reaper.Reap()
- add Options.InitSinkWriter()
- move sinks init to main()
- increase NewSinkWriter coverage
- use Reaper.logger instead of GetLogger(ctx)
- remove unused InitSQLConnPoolForMonitoredDBIfNil()
- use Reaper.logger instead of GetLogger(ctx)
- remove GetConnByUniqueName() extra call
- move sources and metrics sync into main loop
- use srcL for source specific logging
- rename ver to dbSettings
- Reaper.reapMetricMeasurements(), GetMonitoredDatabaseSettings()
  and ParseLogs() use sources.MonitoredDatabase as argument
- remove gatherersShutDown variable
- remove Reaper.ReadMetrics()
- rename LoadMetricDefs() to LoadMetrics()

Run Details

13 of 194 new or added lines in 8 files covered. (6.7%)

16 existing lines in 3 files now uncovered.

1545 of 4857 relevant lines covered (31.81%)

0.36 hits per line