rust-bitcoin / rust-bitcoin / 13705875885

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4186: Clean up Witness API

Pull request description:

  Enhance Witness struct element access methods:

  - Rename `nth()` to `get()` for clearer slice-like element retrieval
  - Introduce `get_back()` method for flexible reverse indexing
  - Remove redundant `second_to_last()` and `third_to_last()` methods
  - Add `#[track_caller]` to index implementation for better error tracking
  - Update all references to use new method names
  - Improve documentation with usage examples

  The changes provide a more intuitive and consistent approach to accessing witness elements.

  Close #4098

ACKs for top commit:
  Kixunil:
    ACK <a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/3ca3218c236c63a9b006047524e2b47e310f07d9">3ca3218c2
  tcharding:
    ACK 3ca3218c236c63a9b006047524e2b47e310f07d9
  apoelstra:
    ACK 3ca3218c236c63a9b006047524e2b47e310f07d9; successfully ran local tests

Tree-SHA512: 163e7457f2e877ef963c392f004e6478af7

37 of 37 new or added lines in 2 files covered. (100.0%)

21548 of 25956 relevant lines covered (83.02%)

16823.27 hits per line