rust-bitcoin / rust-bitcoin / 13703863065

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4201: Make `hex` in `internals` optional

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/d1d483491f5f0181e60778e557fadd99b44b5d30">d1d483491 Make `hex` in `internals` optional (Martin Habovstiak)

Pull request description:

  The `hex` crate is not always desirable - e.g. when the consumer wants to work with raw data only. We already had this optional in `hashes` but if `hashes` is going to depend on `internals` it would break this property.

  This change makes `hash` optional, since it's easy: there's just one struct that depends on it.

ACKs for top commit:
  tcharding:
    ACK d1d483491f5f0181e60778e557fadd99b44b5d30
  apoelstra:
    ACK d1d483491f5f0181e60778e557fadd99b44b5d30; successfully ran local tests; nice

Tree-SHA512: c20091e6f3f3c73288148f2e434ffa5fd5f

21559 of 25968 relevant lines covered (83.02%)

16800.37 hits per line