djeedai / bevy_hanabi / 13640457354
66%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 30
Run time 6min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 40.055% (-6.7%) from 46.757%
13640457354

push

github

web-flow 
Hierarchical effects and GPU spawn event (#424)

This change introduces hierarchical effects, the ability of an effect to
be parented to another effect through the `EffectParent` component.
Child effects can inherit attributes from their parent when spawned
during the init pass, but are otherwise independent effects. They
replace the old group system, which is entirely removed. The parent
effect can emit GPU spawn events, which are consumed by the child effect
to spawn particles instead of the traditional CPU spawn count. Those GPU
spawn events currently are just the ID of the parent particles, to allow
read-only access to its attribute in _e.g._ the new
`InheritAttributeModifier`.

The ribbon/trail system is also reworked. The atomic linked list based
on `Attribute::PREV` and `Attribute::NEXT` is abandoned, and replaced
with an explicit sort compute pass which orders particles by
`Attribute::RIBBON_ID` first, and `Attribute::AGE` next. The ribbon ID
is any `u32` value unique to each ribbon/trail. Sorting particles by age
inside a given ribbon/trail allows avoiding the edge case where a
particle in the middle of a trail dies, leaving a gap in the list.

A migration guide is provided from v0.14 to the upcoming v0.15 which
will include this change, due to the large change of behavior and APIs.

409 of 2997 new or added lines in 17 files covered. (13.65%)

53 existing lines in 11 files now uncovered.

3208 of 8009 relevant lines covered (40.05%)

18.67 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
62.96
 15.14% src/spawn.rs
10
66.3
 14.88% src/asset.rs
10
78.88
 -1.63% src/attributes.rs
14
52.99
 -1.43% src/graph/expr.rs
14
55.56
 -34.44% src/modifier/attr.rs
24
62.71
 -3.04% src/render/buffer_table.rs
26
61.69
 -8.1% src/modifier/mod.rs
30
57.61
 57.61% src/render/batch.rs
40
45.42
 -4.38% src/render/aligned_buffer_vec.rs
68
15.67
 -17.22% src/plugin.rs
85
68.06
 -3.46% src/lib.rs
89
0.0
 src/render/gpu_buffer.rs
93
0.0
 0.0% src/render/property.rs
162
0.0
 src/render/event.rs
201
40.34
 -18.53% src/render/effect_cache.rs
223
0.0
 src/render/sort.rs
1497
3.45
 1.79% src/render/mod.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
66.3
 14.88% src/asset.rs
1
52.99
 -1.43% src/graph/expr.rs
1
15.67
 -17.22% src/plugin.rs
1
45.42
 -4.38% src/render/aligned_buffer_vec.rs
1
57.61
 57.61% src/render/batch.rs
1
62.71
 -3.04% src/render/buffer_table.rs
1
62.96
 15.14% src/spawn.rs
2
40.34
 -18.53% src/render/effect_cache.rs
2
0.0
 0.0% src/render/property.rs
3
92.98
 -1.8% src/gradient.rs
39
3.45
 1.79% src/render/mod.rs
Jobs
ID Job ID Ran Files Coverage
1 13640457354.1 30
40.05
 GitHub Action Run
Source Files on build 13640457354