rust-bitcoin / rust-bitcoin / 13572583314

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4100: Witness taproot fixes

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/a8168c3f81a76165022af3f3aeec82317d8a6bf1">a8168c3f8<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/889a2668d4c284334a0e3207b014a8d3b14a1ce3"> Add `taproot_leaf_script` methood to `Witness` (Martin Habovstiak)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/59f21a291f08af0029691676f86ac95dad04d8c3">59f21a291</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/889a2668d4c284334a0e3207b014a8d3b14a1ce3"> Add a test case checking `taproot_control_block` (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/e810ecff7cbaeef3007fe7abf98f0fe383bcd219">e810ecff7</a> Fix key/script spend detection in `Witness` (Martin Habovstiak)

Pull request description:

  Fixes #4097

  High priority because it blocks a bunch of work and should be probably swiftly backported.

  My plan is to backport this entire PR and then in the breaking version remove the broken `tapscript` method entirely. Keeping it around would be way too confusing if we're going to have tagged script.

ACKs for top commit:
  tcharding:
    ACK a8168c3f81a76165022af3f3aeec82317d8a6bf1
  apoelstra:
    ACK a8168c3f81a76165022af3f3aeec82317d8a6bf1; successfully ran local tests

Tree-SHA512: 9e3c065f0a1187f39b6d1713723f73c0e14

Coverage Stats

77 of 79 new or added lines in 1 file covered. (97.47%)

1 existing line in 1 file now uncovered.

21115 of 25482 relevant lines covered (82.86%)

17125.94 hits per line