rust-bitcoin / rust-bitcoin / 13571519911

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4076: units: macroize the op implementations

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/814685e551f00a896448b46b195f7dde69c2d32b">814685e55<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d889767273620a395f3938616ab17f3c7bd25a04"> Macroise the NumOpResult tests (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a44a9d31f6ee728e8325e380e1c5500e00227a55">a44a9d31f</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d889767273620a395f3938616ab17f3c7bd25a04"> Add a few impls to the result macro (Andrew Poelstra)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/353c23fa0146bf01c1f4ca9af4b8fdc4a8f092ec">353c23fa0</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d889767273620a395f3938616ab17f3c7bd25a04"> units: pull generic op impls on NumOpResult into macro (Andrew Poelstra)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/21ac5aefe0afb6863545b94b79cec46a09857cd4">21ac5aefe</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d889767273620a395f3938616ab17f3c7bd25a04"> units: extend op reference macro to handle generics and where clauses (Andrew Poelstra)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/ad9564895b2ada7bd0ff510a91986b9b02a45ca8">ad9564895</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d889767273620a395f3938616ab17f3c7bd25a04"> units: replace a gazillion more macro calls with new macro (Andrew Poelstra)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0dc7f6cebdf92e14b73b1e74639f9cce531f5847">0dc7f6ceb</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d889767273620a395f3938616ab17f3c7bd25a04"> units: rearrange a bit of code to prep the next commit (Andrew Poelstra)
a358e79a8 units: allow multiple invocations in impl_op_for_references macro (Andrew Poelstra)
2da332e04 units: introduce impl_op_for_references and use it in three places (Andrew Poelstra)
c90559de8 Derive Copy for NumOpResult (Tobin C. Harding)

Pull request description:

  This introduces a general macro which takes some number of `impl ops::Whatever for ` and replicates them with all the permutations of references. It also takes a syntax which resembles the code for the initial impl block.

  Uses it for all the binary opcodes on `Amount`, `SignedAmount`, `Weight`, `FeeRate`, as well as the numeric mul/div on those types, as well as generic impls on `NumResultOp` (which are expanded to cover more cases).

ACKs for top commit:
  tcharding:
    ACK 814685e551f00a896448b46b195f7dde69c2d32b

Tree-SHA512: 6b2ec3893541e6b854f1ff34566970add70