• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

openbraininstitute / neurodamus / 13500938159
90%

Build:
DEFAULT BRANCH: main
Ran 24 Feb 2025 02:55PM UTC
Jobs 2
Files 48
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

24 Feb 2025 02:55PM UTC coverage: 57.707% (+0.6%) from 57.085%
13500938159

push

github

web-flow
test stimuli (#69)

## Context
We need to expand our testing campaign.

Fix: #60 #62 #77 #78

## Scope
Stimuli is a well defined chunk of code that can be easily tested
extensively. Atm we have 2 test files that tests only parts of the
stimuli object, one in unit and one in integration tests. They should be
collected in 1 file that fully tests everything in the stimuli file.

It should be done as an integration test because we need the full
h.Vector. The mocked version of that used in the unit tests is not
enough for the alrady existing integration tests. The h.Vector is
fundamental for the stimuli object because of the `play` capabilities.

#### Tests
- [x] `SignalSource` methods
  - [x] remove `while ev[-1] < duration:` as we always overshoot
- [x] emit error for shot pulse with `tau_D == tau_R` since we do not
know what should the function be. Better than a divide by 0 error.
- [x] `CurrentSource` methods
- [x] ~~remove `stim_vec_mode` since it is always set to `True`. Let me
know if `_Clamp` is used explicitly somewhere~~ EDIT: used by `Constant`
- [x] `ConductanceSource`
- [x] remove `stim_vec_mode` as it is a copy-paste from `CurrentSource`.
However, since `Constant` is missing here, it is always True
  - [x] fix behavior around 0 for `ConductanceSource`

- [x] after discussion, add assert to be sure that we do not have
regressions

## Testing
This is TESTING!!! (it should sound as: this is SPARTAAA!)

## Blockers:
- [x] Decide what to do with: #77 

## Review
* [ ] PR description is complete
* [ ] Coding style (imports, function length, New functions, classes or
files) are good
* [ ] Unit/Scientific test added
* [ ] Updated Readme, in-code, developer documentation

4 of 37 new or added lines in 1 file covered. (10.81%)

5234 of 9070 relevant lines covered (57.71%)

0.82 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
33
20.16
0.97% neurodamus/core/stimuli.py
Subprojects
ID Flag name Job ID Ran Files Coverage
1 baseline 13500938159.1 24 Feb 2025 02:55PM UTC 48
24.27
GitHub Action Run
2 unit 13500938159.2 24 Feb 2025 02:56PM UTC 48
57.32
GitHub Action Run
Source Files on build 13500938159
  • Tree
  • List 48
  • Changed 2
  • Source Changed 2
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #13500938159
  • ff088645 on github
  • Prev Build on main (#13437764598)
  • Next Build on main (#13517334888)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc