agama-project / agama / 13411639555

73%

Build Type

push

github

Committed by web-flow

Commit Message

Unattended installation reboots automatically after finish the installation (#1940) (#1970)

## Problem

After an unattended installation the user needs to reboot manually which
is not very unattended... it should do it automatically unless the user
wanted to stop in the congrats screen explicitly

- https://trello.com/c/wXYDjhyj (Avoid manual reboot after unattended
installation - part1)
- https://trello.com/c/VNS3L31L (Avoid automatic reboot after unattended
installation - part2)

## Solution - Part1

- Agama reboot command added. Only does something if Agama is in a final
state

```
suse@vikingo-laptop:~$ sudo agama reboot
Cannot reboot the system
Anyhow(The installation has not finished correctly)
```

- Unattended installation try to reboot the system when finished
installing.
```
## AGAMA AUTO calls
  /usr/bin/agama profile import "$url"
  /usr/bin/agama install
  /usr/bin/agama reboot

```

## Solution - Part2

Added the `agama.finish` kernel cmdline argument allowing to stop in the
congrats screen only honored by the unattended installation

By default it will reboot the system unless the `stop` value is given,
maybe would be nice to modify the `agama reboot` call by `agama finish
method` where method could be `reboot|stop|halt|poweroff`, what do you
think?


## Testing

- *Tested manually*

Run Details

22 of 63 new or added lines in 5 files covered. (34.92%)

92 existing lines in 7 files now uncovered.

17765 of 25071 relevant lines covered (70.86%)

36.86 hits per line