|
Ran
|
Jobs
2
|
Files
774
|
Run time
1min
|
Badge
README BADGES
|
push
github
feat(web): rework users interface (#1999) Apart from **eliminating the step introduced in #1821 to force users to enter a password for root**, this PR significantly revamps the interface of the Authentication page (formerly the Users page) to reduce its complexity and make interactions more intuitive. Summarizing a lot, the key changes include improving the first user form and moving the root user authentication methods to a new form. This allows users to easily set or clear authentication methods without having to navigate complex actions. I.e., tables and most dynamic actions have been eliminated, making the page much easier to interact with and enabling users to quickly find the options they need. | Authentication page | Root user form | |-|-| | |  | However, there are still areas for improvement: * Enhance validations and the underlying code that supports them. * Decouple the input with suggestions from the FirstUserForm (move it to the core namespace). * Use a simpler widget/input for adding public SSH keys. While the current one works, it is somewhat complex and not well-suited for these form’s use cases. * Enable the ability to add more than one public SSH key. ## Note for reviewers > [!WARNING] > After commit https://github.com/agama-project/agama/pull/1999/commits/c7c424c62 this PR needs changes done at https://github.com/agama-project/agama/pull/2005 (not merged at the time of writing). Please jump into the branch and use the interface as part of the review process. If interested in the details, check commits. --- Related to https://trello.com/c/7ewFvR0X (internal link)
25 of 51 new or added lines in 6 files covered. (49.02%)
72 existing lines in 2 files now uncovered.19509 of 26981 relevant lines covered (72.31%)
42.73 hits per line
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 4 |
0.0 |
0.0% | rust/agama-server/src/users/web.rs |
| 5 |
60.0 |
service/lib/agama/dbus/users.rb | |
| 17 |
0.0 |
0.0% | rust/agama-lib/src/users/client.rs |
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 9 |
0.0 |
0.0% | rust/agama-lib/src/users/client.rs |
| 63 |
0.0 |
0.0% | rust/agama-server/src/users/web.rs |
| ID | Flag name | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|---|
| 2 | service | 13388983393.2 | 644 |
88.9 |
GitHub Action Run | |
| 2 | rust | 13369983451.2 | 130 |
24.95 |
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|