tarantool / tarantool / 13385696761

87%

master: 88%

Build Type

push

github

Committed by locker

Commit Message

vinyl: take into account deferred DELETEs when creating cache chains

Each cache chain stores the max LSN among all DELETE statements that are
known to fall in the chain. This LSN is required so that an older read
view can ignore the chain, otherwise it could skip tuples deleted after
the read view was created (see the previous commit).

The problem is, apart from regular DELETE statements, there may be so
called "deferred" ones. Deferred DELETE statements aren't written to
secondary indexes immediately on commit - this is done later, when
the primary index is compacted. If we don't find the corresponding
full tuple in the primary index by a partial tuple key fetched from
a secondary index, we skip it and create a cache chain leaping over
it so that we don't read it again on the next scan. We don't take
into account the deferred DELETE LSN in this case, as a result,
we face the same problem we fixed in the previous commit for regular
DELETEs.

To avoid that, let's keep track of the max LSN among all skipped
statements and use it for the cache chain. Note, we have to patch
vy_point_lookup() so that it can keep a DELETE statement instead of
returning NULL - we need it to extract its LSN for the cache. This
changes the stats a bit hence the vinyl/deferred_delete test update.

Closes #11079

NO_DOC=bug fix

(cherry picked from commit d31bd73d6)

Run Details

68783 of 122083 branches covered (56.34%)

17 of 17 new or added lines in 2 files covered. (100.0%)

72 existing lines in 16 files now uncovered.

101459 of 116201 relevant lines covered (87.31%)

2237150.48 hits per line