tarantool / tarantool / 13372903974
87%
master: 88%

LAST BUILD BRANCH: gh-10737
DEFAULT BRANCH: master
Ran
Jobs 1
Files 514
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.311% (-0.04%) from 87.349%
13372903974

push

github

locker 
test: fix flaky vinyl/errinj.test.lua

There are two issues with this test.

The first one is an attempt to make a dead fiber joinable:

```
[039] vinyl/errinj.test.lua                                         [ fail ]
[039]
[039] Test failed! Result content mismatch:
[039] --- vinyl/errinj.result	Thu Jan 30 15:14:04 2025
[039] +++ /tmp/t/rejects/vinyl/errinj.reject	Thu Jan 30 15:20:26 2025
[039] @@ -712,6 +712,7 @@
[039]  ...
[039]  f:set_joinable(true);
[039]  ---
[039] +- error: the fiber is dead
[039]  ...
[039]  ok, err = nil;
[039]  ---
[039] @@ -722,6 +723,8 @@
[039]      ok, err = f:join(0.01)
[039]  until ok;
[039]  ---
[039] +- error: '[string "repeat     box.snapshot()     errinj.set("ERR..."]:1: the fiber
[039] +    is dead'
[039]  ...
[039]  test_run:cmd("setopt delimiter ''");
[039]  ---
[039]
[039] [test-run server "vinyl"] Last 15 lines of the log file /tmp/t/039_vinyl/vinyl.log:
[039]  to --- {1: 970}
[039] ...
[039]
[039] 2025-01-30 15:20:26.164 [58596] main/131/console/unix/:/test_run I> wait vclock: --- {1: 969}
[039] ...
[039]  to --- {1: 970}
[039] ...
[039]
[039] 2025-01-30 15:20:26.173 [58596] main/131/console/unix/:/test_run I> wait vclock: --- {1: 969}
[039] ...
[039]  to --- {1: 970}
[039] ...
```

Apparently, this happens because there's a yield between creating
a fiber and making it joinable, which opens a time window for the
fiber to complete. Fix the issue by eliminating the yield.

The second issue is an attempt to cancel a dead fiber:

```
[012] Test failed! Result content mismatch:
[012] --- vinyl/errinj.result	Mon Feb 17 14:42:17 2025
[012] +++ /tmp/t/rejects/vinyl/errinj.reject	Mon Feb 17 14:46:05 2025
[012] @@ -220,6 +220,7 @@
[012]  ...
[012]  fiber.cancel(f1)
[012]  ---
[012] +- error: the fiber is dead
[012]  ...
[012]  fiber.sleep(0.1)
[012]  ---
```

This issue is caused by the read page timeout being too small -
the fiber manages to complete before it's cancelled. Let's use
the ERRINJ_VY_READ_PAGE_DELAY instea... (continued)

68758 of 122065 branches covered (56.33%)

101440 of 116182 relevant lines covered (87.31%)

2178127.51 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
90.7
 -0.07% src/box/applier.cc
1
95.78
 -0.05% src/box/iproto.cc
1
95.36
 -0.31% src/box/raft.c
1
95.15
 -0.13% src/box/replication.cc
1
93.72
 -0.16% src/box/txn_limbo.c
1
92.81
 -0.72% src/box/vy_point_lookup.c
1
87.5
 -1.59% src/box/xlog.h
1
97.41
 0.02% src/lib/vclock/vclock.c
2
87.23
 -0.07% src/box/vy_run.c
2
84.26
 -0.21% src/box/xlog.c
2
93.03
 -0.21% src/lib/core/fiber.c
2
94.11
 -0.39% src/lua/fiber.c
3
94.44
 -0.98% src/box/gc.c
3
91.03
 -0.2% src/box/vy_scheduler.c
3
22.64
 -0.04% src/lib/uri/uri_parser.c
4
94.24
 -0.74% src/box/xrow_update_field.c
4
93.31
 -1.27% src/lib/swim/swim_io.c
4
81.82
 -12.12% src/lua/minifio.c
8
60.42
 -5.56% src/lib/core/fio.c
20
90.65
 -0.65% src/box/box.cc
Jobs
ID Job ID Ran Files Coverage
1 13372903974.1 514
87.31
 GitHub Action Run
Source Files on build 13372903974