Ouranosinc / xclim / 13374599908

92%

Build Type

push

github

Committed by web-flow

Commit Message

Dynamic time selection (#2055)

### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #1987
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGELOG.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?
The PR improves the `select_time` function providing the possibility to
select time based on `xr.DataArray` of days of year.
- Move `_get_doys` outside `select_time`
- Create `mask_between_doys` function
- Edit `select_time` to work with the new workflow to select time with
doys

### Other information:
I've run pytest but I had an error (ERROR
tests/test_sdba/test_adjustment.py::TestLoci::test_reduce_dims) and a
failed (FAILED tests/test_modules.py::test_encoding - AttributeError:
module '_locale' has no attribute 'nl_langinfo') but I don't know how to
fix this.

Run Details

60 of 64 new or added lines in 2 files covered. (93.75%)

4 existing lines in 2 files now uncovered.

9604 of 10679 relevant lines covered (89.93%)

7.62 hits per line