rust-bitcoin / rust-bitcoin / 13357069025

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4007: Introduce monadic `NumOpResult` type

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/6244cb75faf62aed4b47d63a59d14cb766e4e7a8">6244cb75f Introduce monadic AmountOpResult (Tobin C. Harding)

Pull request description:

  We would like to return an error when doing math ops on amount types. We cannot however use the stdlib `Result` or `Option` because we want to implement ops on the result type.

  Add an `NumOpResult` type. Return this type from all math operations on `Amount` and `SignedAmount`.

  Implement `core::iter::Sum` for the new type to allow summing iterators of amounts.

  Note please this removes `AddAssign` impls for amount types.

ACKs for top commit:
  apoelstra:
    ACK 6244cb75faf62aed4b47d63a59d14cb766e4e7a8; successfully ran local tests; let's do it -- but definitely want the followup issues addressed
  Kixunil:
    ACK 6244cb75faf62aed4b47d63a59d14cb766e4e7a8

Tree-SHA512: 7a105acb1d183f71cc1af32f39c622d9d64

364 of 457 new or added lines in 5 files covered. (79.65%)

21188 of 25647 relevant lines covered (82.61%)

16983.34 hits per line