rust-bitcoin / rust-bitcoin / 13348180963

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4055: hashes: Only enable hex/std, and hex/alloc when hex is

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/7c12d92bc3011e1305238f0f5d3b155a01875814">7c12d92bc<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3fb5275e161969b8e74a6f10fe2bb3d929d1dfff"> Only enable hex/std, alloc when hex is (Jamil Lambert, PhD)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/11770cac1c6efbe03c4dded93b22426832ff87cd">11770cac1</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3fb5275e161969b8e74a6f10fe2bb3d929d1dfff"> Add hashes to io dev-depencies and require hex (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/e7c6564d38346a8100be08a43554bfc95cdbb34d">e7c6564d3</a> Add missing hex feature gate (Jamil Lambert, PhD)

Pull request description:

  `hex/std` and `hex/alloc` should only be included if optional dependency `hex` is enabled.  A bunch of tests that need `hex` relied on an `alloc` feature gate to ensure `hex/alloc` was enabled.

  Add feature gates to the tests that require `hex`.

  Add `?` so `hex/alloc` or `hex/std` are only included if the optional feature `hex` is enabled.

  Audit rest of crates `Cargo.toml` files: no other cases found.

  Close #4035

ACKs for top commit:
  Kixunil:
    ACK 7c12d92bc3011e1305238f0f5d3b155a01875814
  apoelstra:
    ACK 7c12d92bc3011e1305238f0f5d3b155a01875814; successfully ran local tests; Played with cargo a bit; `cargo tree` seems to confirm that you can mix dev and non-dev dependencies like this.

Tree-SHA512: bd752d3c0a2797566df05ef0b29ad61e61f

20975 of 25341 relevant lines covered (82.77%)

17244.27 hits per line