e1a120dc-6519-4c6a-a074-de38a9ffd346
28%
master: 90%

Ran 14 Feb 2025 09:33PM UTC

Jobs 1

Files 350

Run time 1min

Badge

Embed ▾

Committed 14 Feb 2025 09:25PM UTC coverage: 27.513% (-61.8%) from 89.294%

Build # e1a120dc-6519-4c6a-a074-de38a9ffd346

Build Type

Pull #14640

circleci

Committed by

luddwichr

Commit Message

fix(platform-express) respect existing parser middlewares when using Express 5

Express 5 made the router public API again and renamed the field from app._router to app.router.
This broke the detection mechanism whether a middleware named "jsonParser" or "urlencodedParser"
is already registered or not.
Unfortunately, https://github.com/nestjs/nest/pull/14574/ only fixed the issue partially.
This commit now uses app.router everywhere.
To avoid future regressions a test was added to verify the expected behavior.

Pull Request Pull Request #14640: fix(platform-express) respect custom parser middlewares in Express 5

Run Details

250 of 3354 branches covered (7.45%)

2201 of 8000 relevant lines covered (27.51%)

0.57 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	50.0	-50.0%	packages/common/pipes/file/file-validator.interface.ts
1	50.0	-50.0%	packages/microservices/deserializers/identity.deserializer.ts
1	50.0	-50.0%	packages/microservices/errors/corrupted-packet-length.exception.ts
1	66.67	-33.33%	packages/microservices/errors/invalid-grpc-package-definition-missing-package-definition.exception.ts
1	66.67	-33.33%	packages/microservices/errors/invalid-grpc-package-definition-mutex.exception.ts
1	66.67	-33.33%	packages/microservices/errors/invalid-grpc-package.exception.ts
1	66.67	-33.33%	packages/microservices/errors/invalid-grpc-service.exception.ts
1	50.0	-50.0%	packages/microservices/errors/invalid-json-format.exception.ts
1	66.67	-33.33%	packages/microservices/errors/invalid-kafka-client-topic.exception.ts
1	66.67	-33.33%	packages/microservices/errors/invalid-proto-definition.exception.ts
1	50.0	-50.0%	packages/microservices/serializers/identity.serializer.ts
1	66.67	-33.33%	packages/websockets/errors/invalid-socket-port.exception.ts
1	91.67	-8.33%	packages/websockets/errors/ws-exception.ts
1	50.0	-50.0%	packages/websockets/utils/compare-element.util.ts
2	50.0	-50.0%	packages/common/module-utils/utils/generate-options-injection-token.util.ts
2	58.33	-16.67%	packages/common/utils/cli-colors.util.ts
2	80.0	-20.0%	packages/common/utils/validate-module-keys.util.ts
2	50.0	-50.0%	packages/core/helpers/get-class-scope.ts
2	50.0	-50.0%	packages/core/helpers/is-durable.ts
2	75.0	-25.0%	packages/core/injector/internal-core-module/internal-core-module.ts
2	40.0	-40.0%	packages/core/injector/modules-container.ts
2	50.0	-50.0%	packages/core/inspector/initialize-on-preview.allowlist.ts
2	50.0	-50.0%	packages/core/repl/native-functions/get-relp-fn.ts
2	50.0	-50.0%	packages/core/repl/native-functions/resolve-repl-fn.ts
2	50.0	-50.0%	packages/core/repl/native-functions/select-relp-fn.ts
2	28.57	-28.57%	packages/core/repl/repl-function.ts
2	64.0	-8.0%	packages/core/router/legacy-route-converter.ts
2	50.0	-50.0%	packages/microservices/ctx-host/base-rpc.context.ts
2	50.0	-50.0%	packages/microservices/ctx-host/redis.context.ts
2	40.0	-40.0%	packages/microservices/deserializers/kafka-request.deserializer.ts
3	70.0	-30.0%	packages/common/decorators/core/injectable.decorator.ts
3	79.07	-6.98%	packages/common/decorators/http/route-params.decorator.ts
3	57.14	-42.86%	packages/common/pipes/default-value.pipe.ts
3	25.0	-75.0%	packages/common/utils/select-exception-filter-metadata.util.ts
3	50.0	-50.0%	packages/core/exceptions/external-exception-filter.ts
3	3.45	-10.34%	packages/core/injector/topology-tree/tree-node.ts
3	93.48	-6.52%	packages/microservices/constants.ts
3	40.0	-60.0%	packages/microservices/ctx-host/mqtt.context.ts
3	40.0	-60.0%	packages/microservices/ctx-host/nats.context.ts
3	40.0	-60.0%	packages/microservices/ctx-host/tcp.context.ts
4	50.0	-50.0%	packages/core/injector/helpers/provider-classifier.ts
4	33.33	-66.67%	packages/core/injector/internal-providers-storage.ts
4	20.0	-80.0%	packages/core/repl/assign-to-object.util.ts
4	20.0	-80.0%	packages/microservices/container.ts
4	33.33	-66.67%	packages/microservices/ctx-host/rmq.context.ts
4	42.86	-57.14%	packages/microservices/serializers/mqtt-record.serializer.ts
4	42.86	-57.14%	packages/microservices/serializers/rmq-record.serializer.ts
5	25.0	-62.5%	packages/common/pipes/file/file-type.validator.ts
5	50.0	-41.67%	packages/common/utils/validate-each.util.ts
5	37.5	-62.5%	packages/core/helpers/router-method-factory.ts
5	28.57	-71.43%	packages/core/pipes/params-token-factory.ts
5	44.44	-55.56%	packages/core/router/utils/exclude-route.util.ts
5	50.0	-50.0%	packages/microservices/serializers/nats-record.serializer.ts
5	28.57	-71.43%	packages/websockets/factories/server-and-event-streams-factory.ts
6	58.82	-35.29%	packages/common/pipes/parse-int.pipe.ts
6	45.45	-54.55%	packages/common/services/utils/is-log-level-enabled.util.ts
6	12.5	-75.0%	packages/common/utils/merge-with-values.util.ts
6	15.38	-23.08%	packages/core/discovery/discoverable-meta-host-collection.ts
6	25.0	-75.0%	packages/core/helpers/external-proxy.ts
6	27.27	-54.55%	packages/core/injector/helpers/transient-instances.ts
6	45.45	-54.55%	packages/core/repl/native-functions/help-repl-fn.ts
6	22.22	-66.67%	packages/microservices/deserializers/incoming-response.deserializer.ts
6	33.33	-66.67%	packages/microservices/deserializers/kafka-response.deserializer.ts
6	40.0	-60.0%	packages/microservices/deserializers/nats-request-json.deserializer.ts
6	45.45	-54.55%	packages/microservices/deserializers/nats-response-json.deserializer.ts
6	22.22	-66.67%	packages/microservices/factories/rpc-params-factory.ts
6	25.0	-75.0%	packages/websockets/factories/ws-params-factory.ts
7	16.67	-58.33%	packages/common/pipes/file/max-file-size.validator.ts
7	36.36	-63.64%	packages/core/helpers/handler-metadata-storage.ts
7	50.0	-31.82%	packages/core/injector/internal-core-module/internal-core-module-factory.ts
7	12.5	-87.5%	packages/core/middleware/resolver.ts
7	22.22	-77.78%	packages/core/pipes/pipes-consumer.ts
7	22.22	-77.78%	packages/microservices/ctx-host/kafka.context.ts
7	30.0	-70.0%	packages/microservices/helpers/grpc-helpers.ts
8	33.33	-66.67%	packages/common/pipes/file/parse-file-pipe.builder.ts
8	20.0	-80.0%	packages/core/helpers/context-creator.ts
8	11.11	-88.89%	packages/microservices/context/request-context-host.ts
8	18.18	-72.73%	packages/microservices/deserializers/incoming-request.deserializer.ts
8	20.0	-80.0%	packages/microservices/record-builders/nats.record-builder.ts
8	20.0	-80.0%	packages/microservices/record-builders/rmq.record-builder.ts
8	20.0	-80.0%	packages/websockets/sockets-container.ts
9	66.67	-33.33%	packages/common/utils/shared.utils.ts
9	8.33	-75.0%	packages/core/injector/settlement-signal.ts
9	7.69	-34.62%	packages/core/injector/topology-tree/topology-tree.ts
9	16.67	-75.0%	packages/core/inspector/deterministic-uuid-registry.ts
9	30.77	-69.23%	packages/core/repl/native-functions/methods-repl-fn.ts
9	30.77	-69.23%	packages/microservices/context/rpc-proxy.ts
9	50.0	-50.0%	packages/microservices/server/server-factory.ts
9	35.71	-64.29%	packages/websockets/context/exception-filters-context.ts
10	31.25	-62.5%	packages/common/pipes/parse-float.pipe.ts
10	16.67	-83.33%	packages/core/helpers/http-adapter-host.ts
10	8.33	-83.33%	packages/core/injector/compiler.ts
10	29.41	-58.82%	packages/platform-express/multer/interceptors/file-fields.interceptor.ts
10	33.33	-66.67%	packages/platform-express/multer/multer.module.ts
10	23.08	-76.92%	packages/platform-express/multer/multer/multer.utils.ts
11	40.0	-55.0%	packages/core/helpers/messages.ts
11	40.91	-50.0%	packages/microservices/client/client-proxy-factory.ts
11	26.67	-73.33%	packages/websockets/context/ws-proxy.ts
12	20.0	-80.0%	packages/common/module-utils/utils/get-injection-providers.util.ts
12	29.41	-70.59%	packages/common/pipes/parse-date.pipe.ts
12	29.41	-70.59%	packages/core/exceptions/exceptions-handler.ts
12	29.41	-70.59%	packages/core/exceptions/external-exceptions-handler.ts
12	14.29	-85.71%	packages/core/router/router-proxy.ts
12	14.29	-85.71%	packages/core/router/utils/flatten-route-paths.util.ts
12	14.29	-85.71%	packages/microservices/utils/transform-pattern.utils.ts
12	29.41	-70.59%	packages/platform-express/multer/interceptors/any-files.interceptor.ts
12	29.41	-70.59%	packages/platform-express/multer/interceptors/file.interceptor.ts
12	29.41	-70.59%	packages/platform-express/multer/interceptors/files.interceptor.ts
12	29.41	-70.59%	packages/platform-express/multer/interceptors/no-files.interceptor.ts
12	29.41	-70.59%	packages/websockets/exceptions/ws-exceptions-handler.ts
13	23.53	-76.47%	packages/core/injector/opaque-key-factory/by-reference-module-opaque-key-factory.ts
13	18.75	-81.25%	packages/microservices/helpers/kafka-logger.ts
14	17.65	-41.18%	packages/common/file-stream/streamable-file.ts
14	30.0	-70.0%	packages/common/pipes/parse-bool.pipe.ts
14	31.82	-63.64%	packages/common/pipes/parse-uuid.pipe.ts
14	22.22	-77.78%	packages/core/guards/guards-consumer.ts
14	22.22	-77.78%	packages/core/hooks/before-app-shutdown.hook.ts
14	22.22	-77.78%	packages/core/hooks/on-app-bootstrap.hook.ts
14	22.22	-77.78%	packages/core/hooks/on-app-shutdown.hook.ts
14	22.22	-77.78%	packages/core/hooks/on-module-destroy.hook.ts
14	22.22	-77.78%	packages/core/hooks/on-module-init.hook.ts
14	12.5	-87.5%	packages/microservices/record-builders/mqtt.record-builder.ts
15	23.81	-71.43%	packages/common/pipes/parse-enum.pipe.ts
15	28.57	-71.43%	packages/core/interceptors/interceptors-consumer.ts
15	11.76	-88.24%	packages/microservices/serializers/kafka-request.serializer.ts
16	26.92	-61.54%	packages/core/exceptions/base-exception-filter.ts
16	15.0	-80.0%	packages/core/router/paths-explorer.ts
16	11.11	-88.89%	packages/core/router/route-params-factory.ts
17	12.0	-68.0%	packages/core/injector/abstract-instance-resolver.ts
17	35.48	-54.84%	packages/microservices/helpers/tcp-socket.ts
17	14.29	-80.95%	packages/websockets/gateway-metadata-explorer.ts
18	16.0	-72.0%	packages/core/helpers/context-utils.ts
18	28.0	-72.0%	packages/microservices/context/exception-filters-context.ts
19	11.54	-73.08%	packages/core/injector/lazy-module-loader/lazy-module-loader.ts
19	13.04	-82.61%	packages/core/repl/native-functions/debug-repl-fn.ts
19	26.92	-73.08%	packages/core/router/router-exception-filters.ts
20	25.93	-74.07%	packages/core/exceptions/external-exception-filter-context.ts
20	4.55	-90.91%	packages/core/helpers/execution-context-host.ts
20	16.67	-83.33%	packages/core/middleware/container.ts
21	14.81	-77.78%	packages/microservices/listener-metadata-explorer.ts
22	8.33	-91.67%	packages/microservices/helpers/kafka-parser.ts
22	11.54	-84.62%	packages/websockets/socket-server-provider.ts
23	31.43	-65.71%	packages/core/services/reflector.service.ts
23	10.0	-76.67%	packages/microservices/module/clients.module.ts
24	16.67	-80.0%	packages/common/pipes/file/parse-file.pipe.ts
24	23.53	-70.59%	packages/core/router/router-module.ts
25	24.0	-50.0%	packages/core/inspector/serialized-graph.ts
26	18.75	-81.25%	packages/core/exceptions/base-exception-filter-context.ts
26	29.17	-54.17%	packages/microservices/client/client-proxy.ts
26	18.18	-78.79%	packages/websockets/exceptions/base-ws-exception-filter.ts
27	36.84	-47.37%	packages/core/middleware/utils.ts
28	9.68	-90.32%	packages/core/router/sse-stream.ts
30	25.58	-69.77%	packages/microservices/helpers/json-socket.ts
31	17.02	-65.96%	packages/core/injector/opaque-key-factory/deep-hashed-module-opaque-key-factory.ts
33	5.26	-86.84%	packages/core/metadata-scanner.ts
35	11.63	-81.4%	packages/core/middleware/route-info-path-extractor.ts
36	13.95	-83.72%	packages/core/interceptors/interceptors-context-creator.ts
38	13.64	-86.36%	packages/core/guards/guards-context-creator.ts
38	13.64	-86.36%	packages/core/pipes/pipes-context-creator.ts
39	11.36	-88.64%	packages/core/middleware/builder.ts
39	12.77	-82.98%	packages/core/router/router-response-controller.ts
41	2.38	-97.62%	packages/core/application-config.ts
43	7.84	-84.31%	packages/core/injector/instance-loader.ts
43	6.9	-74.14%	packages/core/router/route-path-factory.ts
45	7.27	-81.82%	packages/core/inspector/graph-inspector.ts
46	10.91	-83.64%	packages/core/repl/repl-context.ts
48	18.18	-72.73%	packages/microservices/server/server.ts
50	8.2	-81.97%	packages/common/module-utils/configurable-module.builder.ts
51	11.39	-64.56%	packages/microservices/server/server-tcp.ts
52	10.61	-78.79%	packages/core/middleware/routes-mapper.ts
52	15.15	-78.79%	packages/core/router/routes-resolver.ts
53	13.64	-80.3%	packages/common/pipes/parse-array.pipe.ts
55	6.78	-93.22%	packages/microservices/helpers/kafka-reply-partition-assigner.ts
55	12.33	-75.34%	packages/websockets/web-sockets-controller.ts
65	10.34	-74.71%	packages/microservices/client/client-tcp.ts
65	13.4	-67.01%	packages/microservices/listeners-controller.ts
68	13.58	-83.95%	packages/microservices/context/rpc-context-creator.ts
69	9.52	-65.71%	packages/microservices/server/server-nats.ts
71	12.05	-85.54%	packages/websockets/context/ws-context-creator.ts
72	10.28	-67.29%	packages/microservices/client/client-nats.ts
74	6.54	-69.16%	packages/microservices/server/server-redis.ts
79	12.96	-73.15%	packages/core/helpers/external-context-creator.ts
81	7.69	-69.23%	packages/microservices/server/server-rmq.ts
82	13.71	-66.13%	packages/microservices/client/client-redis.ts
82	8.18	-74.55%	packages/microservices/server/server-mqtt.ts
85	15.38	-65.38%	packages/core/router/router-explorer.ts
86	8.84	-58.5%	packages/microservices/client/client-rmq.ts
92	12.17	-80.0%	packages/core/injector/container.ts
94	9.48	-81.03%	packages/common/pipes/validation.pipe.ts
94	18.52	-69.63%	packages/microservices/client/client-mqtt.ts
103	8.77	-90.35%	packages/core/router/router-execution-context.ts
107	9.35	-76.98%	packages/microservices/server/server-kafka.ts
123	8.93	-73.21%	packages/microservices/client/client-kafka.ts
129	8.0	-73.71%	packages/microservices/client/client-grpc.ts
132	16.46	-80.49%	packages/core/injector/instance-wrapper.ts
133	8.62	-76.44%	packages/core/injector/module.ts
169	7.32	-82.44%	packages/core/scanner.ts
201	5.69	-81.71%	packages/microservices/server/server-grpc.ts
221	5.36	-78.93%	packages/core/injector/injector.ts

Jobs

ID	Job ID	Ran	Files	Coverage
1	e1a120dc-6519-4c6a-a074-de38a9ffd346.1	14 Feb 2025 09:33PM UTC	350	27.51

nestjs / nest / e1a120dc-6519-4c6a-a074-de38a9ffd346
28%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build e1a120dc-6519-4c6a-a074-de38a9ffd346

nestjs / nest / e1a120dc-6519-4c6a-a074-de38a9ffd346 28% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build e1a120dc-6519-4c6a-a074-de38a9ffd346

nestjs / nest / e1a120dc-6519-4c6a-a074-de38a9ffd346
28%
master: 90%

README BADGES
x