e1a120dc-6519-4c6a-a074-de38a9ffd346

Committed 14 Feb 2025 09:25PM UTC coverage: 27.513% (-61.8%) from 89.294%

Build # e1a120dc-6519-4c6a-a074-de38a9ffd346

Build Type

Pull #14640

circleci

Committed by

luddwichr

Commit Message

fix(platform-express) respect existing parser middlewares when using Express 5

Express 5 made the router public API again and renamed the field from app._router to app.router.
This broke the detection mechanism whether a middleware named "jsonParser" or "urlencodedParser"
is already registered or not.
Unfortunately, https://github.com/nestjs/nest/pull/14574/ only fixed the issue partially.
This commit now uses app.router everywhere.
To avoid future regressions a test was added to verify the expected behavior.

Pull Request Pull Request #14640: fix(platform-express) respect custom parser middlewares in Express 5

Run Details

250 of 3354 branches covered (7.45%)

2201 of 8000 relevant lines covered (27.51%)

0.57 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

50.0

/packages/microservices/errors/invalid-json-format.exception.ts

/**
 * @publicApi
 */
export class InvalidJSONFormatException extends Error {
  constructor(err: Error, data: string) {
    super(`Could not parse JSON: ${err.message}\nRequest data: ${data}`);
  }
}

1	/**
2	* @publicApi
3	*/
4	export class InvalidJSONFormatException extends Error {	1✔
5	constructor(err: Error, data: string) {
6	super(`Could not parse JSON: ${err.message}\nRequest data: ${data}`);	×
7	}
8	}

nestjs / nest / e1a120dc-6519-4c6a-a074-de38a9ffd346

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous