13222447978
84%

Ran 09 Feb 2025 05:42AM UTC

Jobs 1

Files 57

Run time 1min

Badge

Embed ▾

Committed 07 Feb 2025 08:20PM UTC coverage: 85.372% (-0.1%) from 85.476%

Build # 13222447978

Build Type

push

github

Committed by

web-flow

Commit Message

Purge requests with no subject delete markers (#6470)

As per [the
ADR](https://github.com/nats-io/nats-architecture-and-design/blob/main/adr/ADR-43.md#purge-api-call-marker),
this adds the `no_markers` flag to the JS API stream purge request, such
that a stream can be purged without leaving behind any subject delete
markers, if they are enabled.

This helps to avoid the "poison pill" problem if there are subjects for
example that are causing problems with a consuming application.

Individual message deletes are less of a concern here because a single
message delete will leave behind at most one marker, which can be
deleted too (and would not be replaced in that case), but a purge can
potentially leave behind lots of markers for lots of subjects, which
could be difficult to sort through by hand otherwise.

Signed-off-by: Neil Twigg <neil@nats.io>

Run Details

68989 of 80810 relevant lines covered (85.37%)

769104.02 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	84.06	-0.06%	src/github.com/nats-io/nats-server/server/memstore.go
2	72.46	-0.45%	src/github.com/nats-io/nats-server/server/avl/seqset.go
2	85.12	0.13%	src/github.com/nats-io/nats-server/server/stream.go
2	82.74	0.0%	src/github.com/nats-io/nats-server/server/jetstream.go
4	94.54	-0.13%	src/github.com/nats-io/nats-server/server/server.go
6	73.44	0.11%	src/github.com/nats-io/nats-server/server/jetstream_api.go
9	86.11	-0.27%	src/github.com/nats-io/nats-server/server/accounts.go
13	80.68	-0.11%	src/github.com/nats-io/nats-server/server/opts.go
20	83.88	-0.36%	src/github.com/nats-io/nats-server/server/raft.go
21	88.14	-0.12%	src/github.com/nats-io/nats-server/server/consumer.go
63	83.04	-0.64%	src/github.com/nats-io/nats-server/server/filestore.go
76	81.02	-0.78%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	13222447978.1	09 Feb 2025 05:42AM UTC	57	85.37	GitHub Action Run

nats-io / nats-server / 13222447978
84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 13222447978

nats-io / nats-server / 13222447978 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 13222447978

nats-io / nats-server / 13222447978
84%

README BADGES
x