agama-project / agama / 13198839713

73%

Build Type

push

github

Committed by web-flow

Commit Message

feat(i18n): In local installation by default use the EFI locale (#1924)

## Problem

- In a local installation Agama by default always uses the English
language in the UI.
- But in a remote installation it uses the language configured in the
browser.
- It would be nice to have something similar also in a local
installation and read the preferred language directly from the system.

## Solution

- Use the language configured in the EFI firmware

### Advantages

- Allows using the user preferred language also in a local installation

### Disadvantages

- Works only with EFI firmware (i.e. does not work on S390)
- The list of supported languages is firmware dependent. Some firmware
might support few languages (the VirtualBox EFI firmware supports only
English or French), some might support quite a lot of languages (my Asus
board offers 7 additional languages besides the English default) and
some firmware might implement none (just using the English default).
- For users it might not be obvious which language is actually
configured in the firmware. At boot time firmware usually displays a
splash screen with vendor logo without any hint about the selected
language. This might be confusing if you buy a second hand laptop and
the previous user used some exotic language...

Although it has some drawbacks and probably only very few users will
benefit from this feature I still find it pretty cool. :sunglasses:
If we later get some bug reports about this feature we can easily
disable it. But I'd like to give it a try... :muscle:

To get a list of languages supported by your firmware run

cat /sys/firmware/efi/efivars/PlatformLangCodes-* | tail -c +5 | tr -cd
'[:print:]'

## Notes

- When connecting remotely it still prefers the browser language, this
change only affects the local installation
- The later "welcome screen" will allow changing the language in the
very first dialog. So if the EFI default is not what the user would like
to see then it can be changed e... (continued)

Run Details

0 of 7 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

17296 of 24392 relevant lines covered (70.91%)

35.53 hits per line