rust-bitcoin / rust-bitcoin / 13080303668

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3981: Do not implement `Default` for `HmacEngine`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/18619a6d0b0bca7b7e3603e260b254b4aae6cebf">18619a6d0<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/e45bc0056c775206fd2e37524b8f7113eadec98a"> api: Run just check-api (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1eb8f1f9e044b4bb613f49d3e1b0073c8d11bb8e">1eb8f1f9e</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/e45bc0056c775206fd2e37524b8f7113eadec98a"> Add a Hmac::engine function (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c352d376ed4de2958c55dae960c6efd40b263c6d">c352d376e</a> Do not implement Default for HmacEngine (Tobin C. Harding)

Pull request description:

  The `HmacEngine` should be created using a key. Currently we are providing a `Default` impl that uses `&[]` as the key. This is, I believe, a hangover from when we had a `Default` trait bound somewhere else. It is incorrect and an API footgun - remove it.

  Note this PR includes changes to the bench code in `hmac` that highlights the footgun - pity the poor user we even shot ourselves.

  Patch 2 adds a constructor `Hmac::engine` and uses it in the bench code.

ACKs for top commit:
  Kixunil:
    ACK 18619a6d0b0bca7b7e3603e260b254b4aae6cebf
  apoelstra:
    ACK 18619a6d0b0bca7b7e3603e260b254b4aae6cebf; successfully ran local tests

Tree-SHA512: c96640e7f6ee76300c42dbd82e92a4c1451

0 of 6 new or added lines in 1 file covered. (0.0%)

21032 of 25251 relevant lines covered (83.29%)

17367.22 hits per line