rust-bitcoin / rust-bitcoin / 13074862676

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3978: Delete `TxOut::NULL`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/53bcdefba5f60878cc7049d6e157e21e985bb72c">53bcdefba<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/39e9accb0f949df6b03ce14cfebb7ee0630fdec4"> api: Run just check-api (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/dd2df2bf101f4857a4aa563cd4fc05ccc1f52388">dd2df2bf1</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/39e9accb0f949df6b03ce14cfebb7ee0630fdec4"> Delete `TxOut::NULL` (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a9ffb1571c157fc1f91d549b65a75a98103a5538">a9ffb1571</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/39e9accb0f949df6b03ce14cfebb7ee0630fdec4"> Stop using `TxOut::NULL` in tests (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/313406d6abd9bb3b66cd7defd4bfece8ffd7c6f0">313406d6a</a> Optimize `encode_signing_data_to_inner` (Martin Habovstiak)

Pull request description:

  This removes `TxOut::NULL` from our API and replaces the very few occurrences in our code. The PR has three commits so that the first one provably doesn't break anything, and the second one could be dropped if anyone complains about not deprecating but I really hope that won't happen.

  As a side effect this also improves signing performance.

  Closes #3975

ACKs for top commit:
  tcharding:
    ACK 53bcdefba5f60878cc7049d6e157e21e985bb72c
  apoelstra:
    ACK 53bcdefba5f60878cc7049d6e157e21e985bb72c; successfully ran local tests; thanks!! No need to deprecate. Nobody was using this thing except maybe as a test dummy value

Tree-SHA512: c603512c296e192cf2684ee086ff8050e7a

Coverage Stats

28 of 28 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

21033 of 25246 relevant lines covered (83.31%)

17295.21 hits per line