• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Azure / karpenter-provider-azure / 13044040162
94%

Build:
DEFAULT BRANCH: main
Ran 30 Jan 2025 01:48AM UTC
Jobs 1
Files 99
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

30 Jan 2025 01:45AM UTC coverage: 95.39% (-0.05%) from 95.436%
13044040162

push

github

web-flow
fix: properly garbage collecting orphaned network interfaces (#642)

* feat: adding ListNics to instanceprovider interface alongside a refactor of arg related functions to their own file

* feat: adding garbage collection logic for network interfaces and refactoring gc functions slightly

* feat: working poc of ARG Queries and nic garbage collection, need to fix tests

* fix: tests failing due to ListVM

* feat: split nic and vm into their own gc controllers, added shared state between them to prevent conflicts in nic deletion calls

* feat: Add DeleteNic option to instance provider

* docs(code-comment): adding clarification to unremovableNics

* test: instanceprovider.ListNics barebones test and arg fake list nic impl

* fix: bootstrap.sh

* feat: adding in VM List into the networkinterface.garbagecollection controller to avoid attempts to delete nics that are managed by a vm

* refactor: unremovableNics out of the vm gc controller in favor for a cleaner state list

* fix:updating references to cache

* Update pkg/controllers/nodeclaim/garbagecollection/nic_garbagecollection.go

* test: adding composable network interface options to our test utils based on existing karp-core pattern

* test: adding test we don't include unmanaged nics

* test: adding network garbage collection suite and happy path

* test: adding tests for unremovable nics

* test: adding coverage that vm controller cleans up nics

* refactor: renaming controller

* fix: refactor name

* refactor: using import directly

* ci: checking error for controller

* fix: ci

* fix: addressing comments

* Update pkg/controllers/nodeclaim/garbagecollection/instance_garbagecollection.go

* refactor: removing name constant

* refactor: moving to test utils

* fix: removing GetZoneID

* style: improving the readability of the network interface garbage collection tests

* revert: removing lo.FromPtr checks for nodeclaim creation to avoid c... (continued)

219 of 261 new or added lines in 11 files covered. (83.91%)

48319 of 50654 relevant lines covered (95.39%)

0.96 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
71.88
pkg/controllers/nodeclaim/garbagecollection/instance_garbagecollection.go
1
97.44
pkg/test/networkinterfaces.go
5
84.38
pkg/test/virtualmachines.go
6
84.71
0.09% pkg/providers/instance/instance.go
12
79.31
pkg/providers/instance/azureresourcegraphlist.go
17
66.67
pkg/controllers/nodeclaim/garbagecollection/nic_garbagecollection.go
Jobs
ID Job ID Ran Files Coverage
1 13044040162.1 30 Jan 2025 01:48AM UTC 99
95.39
GitHub Action Run
Source Files on build 13044040162
  • Tree
  • List 99
  • Changed 6
  • Source Changed 0
  • Coverage Changed 6
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 7563bcae on github
  • Prev Build on main (#13002510711)
  • Next Build on main (#13081087715)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc