Azure / karpenter-provider-azure / 13044040162

push

github

fix: properly garbage collecting orphaned network interfaces (#642)

* feat: adding ListNics to instanceprovider interface alongside a refactor of arg related functions to their own file

* feat: adding garbage collection logic for network interfaces and refactoring gc functions slightly

* feat: working poc of ARG Queries and nic garbage collection, need to fix tests

* fix: tests failing due to ListVM

* feat: split nic and vm into their own gc controllers, added shared state between them to prevent conflicts in nic deletion calls

* feat: Add DeleteNic option to instance provider

* docs(code-comment): adding clarification to unremovableNics

* test: instanceprovider.ListNics barebones test and arg fake list nic impl

* fix: bootstrap.sh

* feat: adding in VM List into the networkinterface.garbagecollection controller to avoid attempts to delete nics that are managed by a vm

* refactor: unremovableNics out of the vm gc controller in favor for a cleaner state list

* fix:updating references to cache

* Update pkg/controllers/nodeclaim/garbagecollection/nic_garbagecollection.go

* test: adding composable network interface options to our test utils based on existing karp-core pattern

* test: adding test we don't include unmanaged nics

* test: adding network garbage collection suite and happy path

* test: adding tests for unremovable nics

* test: adding coverage that vm controller cleans up nics

* refactor: renaming controller

* fix: refactor name

* refactor: using import directly

* ci: checking error for controller

* fix: ci

* fix: addressing comments

* Update pkg/controllers/nodeclaim/garbagecollection/instance_garbagecollection.go

* refactor: removing name constant

* refactor: moving to test utils

* fix: removing GetZoneID

* style: improving the readability of the network interface garbage collection tests

* revert: removing lo.FromPtr checks for nodeclaim creation to avoid c... (continued)

219 of 261 new or added lines in 11 files covered. (83.91%)

48319 of 50654 relevant lines covered (95.39%)

0.96 hits per line