kobotoolbox / kpi / 13013940587

81%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(exports): tasks stuck in processing TASK-1243 (#5436)

### 📣 Summary
Fixes occasional problem where tasks end up showing as 'Processing'
forever.


### 💭 Notes
Tasks were failing when the celery task started too quickly and tried to
fetch the task before it had actually hit the database. This PR
implements 2 guards against this:
1. Call the tasks from within an on_commit block to ensure they only
start after the task object has made it to the database
2. Automatically catch ObjectDoesNotExist exceptions and retry the task
a hardcoded number of times. `task.retry` takes care of putting some
time in between retries



### 👀 Preview steps
This bug tends to only appear in low traffic when the celery queue is
empty. Make sure `CELERY_TASK_ALWAYS_EAGER` is false.

1. ℹ️ have an account and a project
3. Export the project submissions
4. 🔴 [on main] The job will show as 'Processing' indefinitely. In the
worker logs, you'll see
`kpi.models.import_export_task.SubmissionExportTask.DoesNotExist:
SubmissionExportTask matching query does not exist`
5. 🟢 [on PR] The job will only show as 'Processing' for a few seconds
and then will complete.

Run Details

5928 of 9467 branches covered (62.62%)

22 of 23 new or added lines in 6 files covered. (95.65%)

6 existing lines in 2 files now uncovered.

22595 of 28039 relevant lines covered (80.58%)

0.81 hits per line