MITLibraries / dspace-submission-composer / 12991220863

95%

push

github

In 1105 finalize command (#80)

* Add pragma no cover to type checking blocks

* Update SESClient method arg

* Rename recipient_email_address > recipient_email_addresses and update type hint to list[str] to reflect expected usage
* Update unit tests to account for these changes

* Add DSC DSC_SOURCE_EMAIL env variable

* Update SQSClient var names and logging messages

* Update Config class

* Remove __getattr__ method
* Add workspace, sentry_dsn, aws_region_name, dss_input_queue, and dsc_source_email properties and update calls across repo
* Remove duplicate addHandler call in configure_logger method

* In 1105 finalize command

Why these changes are being introduced:
* A CLI command is need to process the submissions results that are sent to a DSS output queue

How this addresses that need:
* Rename stream > log_stream
* Add finalize CLI command and corresponding CLI test
* Add process_results and send_logs methods to Workflow class and corresponding unit tests
* Add Config call in Workflow module
* Remove SimpleCSV.process_deposit_results method as the class will default to Workflow.process_results
* Reorder fixtures

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1105

* Update Pipfile.lock

* Updates based on discussion in PR #80

* Rename deposit CLI command > submit
* Rename Workflow.run > submit_items
* Rename Workflow.send_logs > report_results and refactor to use report_lines attribute rather than log stream
* Create process_sqs_queue method from refactored process_results functionality but retain process_results method as wrapper method
* Add workflow_specific_processing method and corresponding unit test
* Remove str conversion from SQSClient.process_result_message method
* Remove log stream functionality from CLI
* Remove log stream param from Config.configure_logger and update corresponding unit tests
* Update Config properties to ra... (continued)

81 of 81 new or added lines in 6 files covered. (100.0%)

459 of 460 relevant lines covered (99.78%)

1.0 hits per line