agama-project / agama / 12949892126

73%

Build Type

push

github

Committed by web-flow

Commit Message

fix: prevent reaching the congratulations screen during installation (#1942)

## Problem

Agama determines in which point of the installation it is by the
combination of two values: the
installation phase (startup, config and install) and the isBusy flag.
This method has proven to be
rather fragile.

One of the typical issues is jumping into the "congratulations" screen
when the installation is not even finished. See #1616.

Although we mitigated this problem, it recently appear in our QA
testing.

## Solution

Let's introduce a new phase, "finish", which indicates that the
installation is finished. As simple
as that. So we do not need a combination of two values anymore at that
point. We plan to extend this
approach to other parts.

## Testing

- _Added a new unit test_
- _Tested manually_

Run Details

9 of 11 new or added lines in 5 files covered. (81.82%)

20 existing lines in 3 files now uncovered.

17277 of 24366 relevant lines covered (70.91%)

35.57 hits per line