payjoin / rust-payjoin / 12921784855

83%

Build Type

push

github

Committed by web-flow

Commit Message

Introduce `directory` feature module (#502)

- Allow payjoin and payjoin-directory to share ShortId code.
- define directory::ENCAPSULATED_MESSAGE_BYTES: usize = 8192;

other constants (like tag size) seem more appropriate for bitcoin_hpke
or bitcoin_ohttp to define than for the directory module.

Close #418 

In order to allow `directory` to be used independetly, I needed to make
the `_core` feature compile `send` and `receive` modules, and made `v1`
and `v2` features export their feature modules explicitly. That way when
`directory` is enabled explicitly with no-default-features no other code
gets compiled.

Some exclusive v1 features are used for testing v2, so perhaps these
should be exported in `_test-util` as well i.e. `#[cfg(any(feature =
"v1", feature = "_test-util")]` in a follow up.

This also revealed some indirection in the `bech32` module,
where some of it is used for `directory` and some for `v2` OhttpKeys
serialization

Run Details

133 of 147 new or added lines in 11 files covered. (90.48%)

4 existing lines in 2 files now uncovered.

3576 of 4581 relevant lines covered (78.06%)

1005.32 hits per line