12874640319
83%

Ran 20 Jan 2025 07:34PM UTC

Jobs 1

Files 32

Run time 1min

Badge

Embed ▾

Committed 20 Jan 2025 07:32PM UTC coverage: 72.12% (-0.2%) from 72.327%

Build # 12874640319

Build Type

push

github

Committed by

web-flow

Commit Message

Organize feature separation for ergonomics (#501)

- first patch closes #393 
- second patch hard-closes #392 hard with an explicit `v1` feature
- make `payjoin/v2` a default feature
- Fix warning for module docs not found with conditional compilation
- Lint previously un-linted v1 payjoin-cli/e2e tests
- Close #499 (Configure v1 checks to use _danger-local-https)

In making these changes I also considered an organizational structure
that looks more like this:

`payjoin::receive::{InputPair, Error...}` `payjoin::v1::receive`,
`payjoin::v2::receive`

But I think that's more trouble than it's worth, and also breaks the
hierarchy that's most effective for producing and maintaining this
software, so I'm inclined to leave it as is, leaving `send`, `receive`
modules abstraction with version-specific submodule implementations.

This makes it easier for us to effectuate #500

Run Details

3531 of 4896 relevant lines covered (72.12%)

946.77 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
19	0.0	0.0%	payjoin-cli/src/app/v1.rs

Jobs

ID	Job ID	Ran	Files	Coverage
1	12874640319.1	20 Jan 2025 07:34PM UTC	32	72.12	GitHub Action Run

payjoin / rust-payjoin / 12874640319
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 12874640319

payjoin / rust-payjoin / 12874640319 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 12874640319

payjoin / rust-payjoin / 12874640319
83%

README BADGES
x