kobotoolbox / kpi / 12893603836

81%

master: 76%

push

github

fix(auditLogs): do not try to create logs after 404s (#5431)

### 📣 Summary
Return correct error message when page isn't found.


### 📖 Description
404s were returning as 500s because of a bug in the audit log
middleware. This fixes that.


### 💭 Notes
If a request 404s, `request.resolver_match` will be None. This was
causing a 500 error in the middleware when non-GET requests were made to
missing pages because it tries to look at
`request.resolver_match.url_name`.


### 👀 Preview steps

Bug template:
1. ℹ️ have an account and a project
2. From the terminal, run `curl -X POST kf.kobo.local:8080/api/v2/fake/`
3. 🔴 [on main] The response will be a 500 with the error `NoneType has
no attribute 'url_name'`
4. 🟢 [on PR] The response will be a 404

5850 of 9358 branches covered (62.51%)

2 of 2 new or added lines in 1 file covered. (100.0%)

22327 of 27726 relevant lines covered (80.53%)

0.81 hits per line